fix(t3x): auto-resume never fired — 'thread-advanced' false cancellation on settled turns - #9
Merged
Merged
Conversation
…d turn settles The projection populates projection_threads.latest_turn_id only while a turn is active, so a usage limit that lands mid-turn captures the running turn's id in the guard baseline — and by wake time (turn settled, session idle) the snapshot reports latestTurn: null. cancelReason treated that null as evidence the thread had advanced and cancelled the pending resume, which killed every real-world resume (observed 3/3 on 2026-07-25; firedAtMs was empty across all threads — the feature had never fired). Advancement now requires positive evidence: a different, NON-NULL turn id. Null means "no active turn" — the expected state after a settled limit. User takeovers stay covered by the user-took-over guard (checked first) and active work by the progressing guard. Regression coverage: a guards.test.ts unit case (null-at-fire vs non-null baseline must not cancel) plus a Reactor.test.ts integration case replaying the production shape (schedule mid-running-turn, settle to latestTurn: null, assert the resume fires with no thread-advanced note). Both verified to fail against the previous guard. Fixes #6 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6.
What was broken
Every real-world auto-resume was cancelled at wake time with "Auto-resume cancelled: thread-advanced." — observed 3/3 on 2026-07-25 (threads
33c06a5a,8f31df69,bb66acc2, all cancelled within 2s of their shared window reset), and the durable state showedfiredAtMs: []everywhere: the feature had never successfully fired.Root cause
ProjectionSnapshotQuery.getSnapshot()reads threads from the SQLite projection, wherelatestTurnis joined onprojection_threads.latest_turn_id— a column populated only while a turn is active. A usage limit normally lands mid-turn, so the guard baseline captures the running turn's id; by wake time the turn has settled and the snapshot reportslatestTurn: null. The guardread
null !== "<turnId>"as advancement and cancelled — then nothing ever re-armed, because an idle thread emits no further rejection events.The fix
thread-advancednow requires positive evidence — a different, non-null turn id:nullat fire time means "no active turn", the expected state after a settled limit. Genuine user takeovers remain covered byuser-took-over(checked first, keyed on the newest user message); active work remains covered byprogressing. Known residual: an auto-started turn that both runs and settles during the wait with no user message is no longer detected via turn id — acceptable against a guard that previously cancelled 100% of legitimate resumes.Testing
guards.test.ts): fire-timelatestTurn: nullvs non-null baseline → no cancellation; plus the converse (baseline null, turn present → still cancels).Reactor.test.ts): replays the production incident — rejection arrives mid-running-turn, thread settles tolatestTurn: null+ sessionstoppedduring the wait, wake must dispatch exactly one resume turn and post no thread-advanced note.src/t3x/autoResumesuite: 69/69 across 4 consecutive runs.pnpm typecheckoutput identical tomain(two pre-existing non-error diagnostics in untouched files).🤖 Generated with Claude Code